Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in deserializing counterfactual explainer #1554

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 13, 2022

Description

The deserializing of the counterfactual had a bug which was causing the retraining of counterfactual explainer during load().

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #1554 (ac3cb9e) into main (b1cf129) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1554   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files         109      109           
  Lines        5260     5261    +1     
=======================================
+ Hits         4615     4616    +1     
  Misses        645      645           
Flag Coverage Δ
unittests 87.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/responsibleai/managers/counterfactual_manager.py 93.97% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cf129...ac3cb9e. Read the comment docs.

@imatiach-msft
Copy link
Contributor

is there some way to add a test to validate the explainer is not getting re-trained on load?

@gaugup gaugup merged commit b210eb6 into main Jul 14, 2022
@gaugup gaugup deleted the gaugup/FixCFExplainerLoading branch July 14, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants