Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more classification metrics to erroranalysis #1575

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 21, 2022

Description

Add computation of false_positive_rate, false_negative_rate and selection_rate to metrics module in erroranalysis.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup requested a review from imatiach-msft as a code owner July 21, 2022 22:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #1575 (72b1fe5) into main (4df0cb2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
+ Coverage   88.04%   88.07%   +0.03%     
==========================================
  Files         109      109              
  Lines        5295     5310      +15     
==========================================
+ Hits         4662     4677      +15     
  Misses        633      633              
Flag Coverage Δ
unittests 88.07% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
erroranalysis/erroranalysis/_internal/constants.py 100.00% <100.00%> (ø)
erroranalysis/erroranalysis/_internal/metrics.py 89.47% <100.00%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df0cb2...72b1fe5. Read the comment docs.

@gaugup gaugup enabled auto-merge (squash) July 25, 2022 22:19
@gaugup gaugup merged commit 5a5222e into main Jul 25, 2022
@gaugup gaugup deleted the gaugup/AddMoreClassificationMetrics branch July 25, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants