[Bugfix] Fix Dropdown bug and Update styling for feature balance measures #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-kashyap
requested review from
romanlutz,
xuke444,
tongyu-microsoft,
vinuthakaranth and
RubyZ10
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1583 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 109 109
Lines 5379 5379
=======================================
Hits 4785 4785
Misses 594 594
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
imatiach-msft
approved these changes
Jul 26, 2022
ms-kashyap
changed the title
1 similar comment
imatiach-msft
approved these changes
Jul 28, 2022
imatiach-msft
approved these changes
Jul 28, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where the 0th element in a dropdown can't be selected because it fails the
if (item?.key)check.Addresses the open comments in PR #1512, namely:
<Dropdown>styles into the styles file<Label>can't be used in feature balance measures descriptionWhen a
<Text>wraps to a newline (due to there being lots of text), the label and text don't render properly.The
Bolded textis a<Label>and to the right of it is a<Text>:Checklist