Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new interpret-vision library skeleton #1586

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

jamesbchao
Copy link
Contributor

Description

Add skeleton library for interpret-vision component.
It will be part of the RAI vision dashboard.

This PR just sets up the skeleton framework. Most of the code was generated via:

nx generate @nrwl/react:library interpret-vision --publishable --importPath @responsible-ai/interpret-vision
and then files were overwritten based on other projects to be as similar as possible, after which yarn lintfix was applied.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@jamesbchao jamesbchao changed the title skeleton add new interpret-vision library skeleton Jul 26, 2022
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-new branch from 92a2281 to b17a9ea Compare July 26, 2022 21:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #1586 (ea106b6) into main (24ae91a) will increase coverage by 0.75%.
The diff coverage is n/a.

❗ Current head ea106b6 differs from pull request most recent head eb416d1. Consider uploading reports for the commit eb416d1 to get more accurate results

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
+ Coverage   88.12%   88.87%   +0.75%     
==========================================
  Files         109      109              
  Lines        5323     5332       +9     
==========================================
+ Hits         4691     4739      +48     
+ Misses        632      593      -39     
Flag Coverage Δ
unittests 88.87% <ø> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ibleai/responsibleai/managers/explainer_manager.py 89.55% <0.00%> (+20.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ae91a...eb416d1. Read the comment docs.

1 similar comment
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-new branch from b17a9ea to eb416d1 Compare July 26, 2022 23:57
1 similar comment
@imatiach-msft
Copy link
Contributor

@jamesbchao can you remove the second commit? Only the first one has been reviewed. I can help with that.

@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-new branch from ea106b6 to eb416d1 Compare July 27, 2022 17:14
@imatiach-msft imatiach-msft merged commit f016daa into main Jul 27, 2022
@imatiach-msft imatiach-msft deleted the jbchao/vision-dashboard-new branch July 27, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants