Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in treeview filtering logic in error analysis package #1593

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Fix bug introduced in recent PR:
#1562
During refactoring of a method the filtering logic broke. This PR fixes the filtering logic again and adds a test to validate the nodes from error analysis constructed json are the same size as the original lightgbm tree exported model file.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft requested a review from gaugup as a code owner July 28, 2022 22:00
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-treeview-filtering branch from 29e2030 to 78c103c Compare July 28, 2022 22:02
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #1593 (8b5dd6b) into main (7319c7d) will increase coverage by 1.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   88.95%   89.98%   +1.03%     
==========================================
  Files         109       38      -71     
  Lines        5379     1638    -3741     
==========================================
- Hits         4785     1474    -3311     
+ Misses        594      164     -430     
Flag Coverage Δ
unittests 89.98% <100.00%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...is/erroranalysis/_internal/surrogate_error_tree.py 87.78% <100.00%> (ø)
erroranalysis/erroranalysis/version.py 100.00% <100.00%> (ø)
responsibleai/responsibleai/_data_validations.py
responsibleai/responsibleai/_tools/__init__.py
responsibleai/responsibleai/exceptions.py
raiwidgets/raiwidgets/error_handling.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
...tools/counterfactual/dashboard_schemas/__init__.py
...i/responsibleai/managers/counterfactual_manager.py
responsibleai/responsibleai/_config/base_config.py
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7319c7d...8b5dd6b. Read the comment docs.

@gaugup
Copy link
Contributor

gaugup commented Jul 28, 2022

looks like linting failed with error. Please check.

1 similar comment
@imatiach-msft imatiach-msft merged commit d968233 into main Jul 29, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-treeview-filtering branch July 29, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants