If feature groups is more than 10, short it to 10 with "Other" for the rest #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
RubyZ10
requested review from
romanlutz,
xuke444,
tongyu-microsoft and
vinuthakaranth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1602 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 110 110
Lines 5415 5415
=======================================
Hits 4815 4815
Misses 600 600
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/FeaturesUtils.ts
Show resolved
Hide resolved
imatiach-msft
approved these changes
Aug 2, 2022
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
gaugup
reviewed
Aug 2, 2022
libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/FeaturesUtils.ts
Show resolved
Hide resolved
tongyu-microsoft
approved these changes
Aug 2, 2022
vinuthakaranth
approved these changes
Aug 3, 2022
libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/FeaturesUtils.ts
Outdated
Show resolved
Hide resolved
1 similar comment
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
1 similar comment
gaugup
approved these changes
Aug 3, 2022
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruby Zhu zhenzhu@microsoft.com
Description
This PR is to fix bug Bug 1874148: Model Overview: feature group is too long for first_name and last_name where it contains a lot of categories
When the feature groups is more than 10, keep the top 10 and have the rest as other under the rows
Before
After
Checklist