[Model Overview]Fix bug: x axis selection is not kept between tab switch #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
RubyZ10
requested review from
romanlutz,
xuke444,
tongyu-microsoft and
vinuthakaranth
as code owners
RubyZ10
changed the title
imatiach-msft
approved these changes
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #1607 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 110 110
Lines 5415 5415
=======================================
Hits 4815 4815
Misses 600 600
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
approved these changes
Aug 3, 2022
1 similar comment
tongyu-microsoft
approved these changes
Aug 3, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruby Zhu zhenzhu@microsoft.com
Fix bug: x axis selection is not kept between tab switch
Bug 1777708: Model Overview: x axis selection is not kept between tab switch
Description
Repro steps:
in metrics visualizations, update x axis from 'accuracy' to 'F1 score',
switch to 'probability distribution' tab, and switch back,
actual: the x axis changes back to 'accuracy'
expected:
the x axis selection for 'F1 score' is kept during tab switches (we keep y axis selection between tab switches, to be consistent, maybe we should keep x axis selection)
gif before fix
gif after fix
Checklist