[ModelOverview] Fix bug- On choosing a specific feature cohort and trying to choose feature cohort again - dropdown has all cohorts selected #1608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruby Zhu zhenzhu@microsoft.com
This PR fix bug Bug 1874154: Model Overview: On choosing a specific feature cohort and trying to choose feature cohort again - dropdown has all cohorts selected
Description
Bug repro steps:
Root cause:
The code try to compare if the selected feature changed or if the selected feature cohorts changed, then it set the selected cohort value with the whole feature cohorts list. Per my understanding, we only need to set the selected cohort with whole feature cohort when user select a new feature.
Fix:
For selected feature cohorts, only update to the original whole feature cohort list when feature changed
gif before fix
gif after fix
Checklist