Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModelOverview] Fix bug- On choosing a specific feature cohort and trying to choose feature cohort again - dropdown has all cohorts selected #1608

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Aug 3, 2022

Signed-off-by: Ruby Zhu zhenzhu@microsoft.com

This PR fix bug Bug 1874154: Model Overview: On choosing a specific feature cohort and trying to choose feature cohort again - dropdown has all cohorts selected

Description

Bug repro steps:

  1. select OS, job title under feature cohorts
  2. Click on choose cohorts
  3. select feature cohorts
  4. deselect all, select one from list and confirm
  5. click on choose cohorts
  6. all feature cohorts are selected again by default

Root cause:
The code try to compare if the selected feature changed or if the selected feature cohorts changed, then it set the selected cohort value with the whole feature cohorts list. Per my understanding, we only need to set the selected cohort with whole feature cohort when user select a new feature.
Fix:
For selected feature cohorts, only update to the original whole feature cohort list when feature changed

gif before fix
dropdownBF

gif after fix
dropdownAF

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #1608 (1104862) into main (5f1482d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1608   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         110      110           
  Lines        5415     5415           
=======================================
  Hits         4815     4815           
  Misses        600      600           
Flag Coverage Δ
unittests 88.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RubyZ10 RubyZ10 enabled auto-merge (squash) August 4, 2022 00:21
@RubyZ10 RubyZ10 merged commit 6a49569 into main Aug 4, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/fixCohortsDropdown branch August 4, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants