Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[300 line limit] Refactor CohortEditor, OverallMetricChart, set max-lines rule for core-ui package #1612

Merged
merged 11 commits into from
Aug 4, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

This PR refactors CohortEditor, OverallMetricChart, set max-lines eslint rule for core-ui package.

Description

For CohortEditor.tsx, this PR creates CohortEditorPanelContent and CohortEditorFilterSection component. So each file now has less than 300 lines of code.

Note: We have a work item to refactor JointDataset.ts. So we exclude JointDataset.ts for 300 line limit rule for now. And once we finish refactoring JointDataset.ts, we can remove JointDataset.ts from the ignore file list.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #1612 (ac90442) into main (4303fa6) will increase coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
+ Coverage   88.91%   89.82%   +0.90%     
==========================================
  Files         110       39      -71     
  Lines        5415     1670    -3745     
==========================================
- Hits         4815     1500    -3315     
+ Misses        600      170     -430     
Flag Coverage Δ
unittests 89.82% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tools/error_analysis/dashboard_schemas/__init__.py
...i/responsibleai/managers/error_analysis_manager.py
...onsibleai/responsibleai/managers/causal_manager.py
responsibleai/responsibleai/_data_validations.py
raiwidgets/raiwidgets/explanation_constants.py
responsibleai/responsibleai/_internal/__init__.py
raiwidgets/raiwidgets/error_analysis_constants.py
raiwidgets/raiwidgets/error_handling.py
responsibleai/responsibleai/_managers/__init__.py
...ponsibleai/responsibleai/rai_insights/constants.py
... and 61 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tongyu-microsoft tongyu-microsoft merged commit b80f2ac into main Aug 4, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/limit300linesPart2 branch August 4, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants