-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[300 line limit] Refactor CohortEditor, OverallMetricChart, set max-lines rule for core-ui package #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponsible-ai-widgets into tongy/limit300lines
…EditorPanelContent
Codecov Report
@@ Coverage Diff @@
## main #1612 +/- ##
==========================================
+ Coverage 88.91% 89.82% +0.90%
==========================================
Files 110 39 -71
Lines 5415 1670 -3745
==========================================
- Hits 4815 1500 -3315
+ Misses 600 170 -430
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
approved these changes
Aug 4, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors CohortEditor, OverallMetricChart, set max-lines eslint rule for core-ui package.
Description
For CohortEditor.tsx, this PR creates CohortEditorPanelContent and CohortEditorFilterSection component. So each file now has less than 300 lines of code.
Note: We have a work item to refactor JointDataset.ts. So we exclude JointDataset.ts for 300 line limit rule for now. And once we finish refactoring JointDataset.ts, we can remove JointDataset.ts from the ignore file list.
Checklist