Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Fix all existing accessibility bugs #1613

Merged
merged 7 commits into from
Aug 5, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Aug 4, 2022

Signed-off-by: Ruby Zhu zhenzhu@microsoft.com

Description

This PR fix below bugs

  1. Bug 1900620: WCAG 4.1.2: Ensures buttons have discernible text (.ms-Panel-closeButton)
    add aria-label "Close" for the close button
    image

2.Bug 1900608: WCAG 4.1.2: Ensures buttons have discernible text (.root-146.ms-Button--icon[type="button"])
add aria-label "Delete" for those delete buttons
image

  1. Bug 1900611: WCAG 4.1.2: Ensures buttons have discernible text (.root-146.ms-Button--icon[type="button"])
    add aria-label "Tooltip button" for the info button
    image

  2. Bug 1898487: WCAG 4.1.2: Ensures buttons have discernible text (#Id_0dcebfe4-d8ab-4159-bd2a-6bf397b985b2)
    add aria-label "Add component" for all the add component buttons
    image

  3. Bug 1898438: WCAG 4.1.2: Ensures every ARIA input field has an accessible name (#dataExplorerCohortDropdown)
    add aria-label "Dataset cohort dropdown" for dataset cohort dropdown
    image

  4. add aria-label "Class importance weights dropdown" for class importance weights dropdown
    image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

RubyZ10 and others added 3 commits August 4, 2022 14:02
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@RubyZ10 RubyZ10 marked this pull request as ready for review August 4, 2022 21:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #1613 (733e173) into main (a7a7179) will decrease coverage by 3.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
- Coverage   88.96%   85.25%   -3.72%     
==========================================
  Files         111       58      -53     
  Lines        5448     2937    -2511     
==========================================
- Hits         4847     2504    -2343     
+ Misses        601      433     -168     
Flag Coverage Δ
unittests 85.25% <ø> (-3.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sponsibleai/responsibleai/rai_insights/__init__.py
...onsibleai/responsibleai/managers/causal_manager.py
responsibleai/responsibleai/_internal/constants.py
...nsibleai/responsibleai/_managers/causal_manager.py
...ponsibleai/responsibleai/_tools/shared/versions.py
...ponsibleai/responsibleai/_tools/shared/__init__.py
...ai/responsibleai/rai_insights/rai_base_insights.py
...tabalanceanalysis/distribution_balance_measures.py
...ibleai/_tools/shared/state_directory_management.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
1 similar comment
@RubyZ10 RubyZ10 enabled auto-merge (squash) August 5, 2022 17:30
@RubyZ10 RubyZ10 merged commit 85f1c86 into main Aug 5, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/accessibility branch August 5, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants