-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] Fix all existing accessibility bugs #1613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
RubyZ10
requested review from
romanlutz,
xuke444,
tongyu-microsoft,
vinuthakaranth and
gaugup
as code owners
August 4, 2022 21:25
tongyu-microsoft
approved these changes
Aug 4, 2022
gaugup
approved these changes
Aug 4, 2022
1 similar comment
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
…responsible-ai-toolbox into zhenzhu/accessibility
1 similar comment
imatiach-msft
approved these changes
Aug 5, 2022
vinuthakaranth
approved these changes
Aug 5, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruby Zhu zhenzhu@microsoft.com
Description
This PR fix below bugs
add aria-label "Close" for the close button
2.Bug 1900608: WCAG 4.1.2: Ensures buttons have discernible text (.root-146.ms-Button--icon[type="button"])
add aria-label "Delete" for those delete buttons
Bug 1900611: WCAG 4.1.2: Ensures buttons have discernible text (.root-146.ms-Button--icon[type="button"])
add aria-label "Tooltip button" for the info button
Bug 1898487: WCAG 4.1.2: Ensures buttons have discernible text (#Id_0dcebfe4-d8ab-4159-bd2a-6bf397b985b2)
add aria-label "Add component" for all the add component buttons
Bug 1898438: WCAG 4.1.2: Ensures every ARIA input field has an accessible name (#dataExplorerCohortDropdown)
add aria-label "Dataset cohort dropdown" for dataset cohort dropdown
add aria-label "Class importance weights dropdown" for class importance weights dropdown
Checklist