Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[300 line limit] Refactor CounterfactualList #1619

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

This PR refactors CounterfactualList, so it contains less than 300 lines.

Description

For CounterfactualList.tsx, this PR creates CounterfactualListColumnName and CounterfactualListDetailsFooter component. So each file now has less than 300 lines of code.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #1619 (110c7a1) into main (b80f2ac) will increase coverage by 8.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1619      +/-   ##
==========================================
+ Coverage   80.35%   88.96%   +8.61%     
==========================================
  Files          41      111      +70     
  Lines        1685     5448    +3763     
==========================================
+ Hits         1354     4847    +3493     
- Misses        331      601     +270     
Flag Coverage Δ
unittests 88.96% <ø> (+8.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/erroranalysis/_internal/error_report/__init__.py 100.00% <0.00%> (ø)
...i/responsibleai/managers/counterfactual_manager.py 97.78% <0.00%> (ø)
.../responsibleai/_managers/counterfactual_manager.py 100.00% <0.00%> (ø)
...ibleai/_tools/causal/dashboard_schemas/__init__.py 100.00% <0.00%> (ø)
...bleai/responsibleai/_managers/explainer_manager.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/__version__.py 100.00% <0.00%> (ø)
...ai/responsibleai/_tools/counterfactual/__init__.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/_internal/utils.py 84.61% <0.00%> (ø)
...eai/responsibleai/databalanceanalysis/constants.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/version.py 100.00% <0.00%> (ø)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tongyu-microsoft tongyu-microsoft merged commit b49b089 into main Aug 5, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/limit300linesPart3 branch August 5, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants