Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vision Dashboard Table View and initial explanation flyout #1621

Merged
merged 6 commits into from
Aug 22, 2022
Merged

Vision Dashboard Table View and initial explanation flyout #1621

merged 6 commits into from
Aug 22, 2022

Conversation

jamesbchao
Copy link
Contributor

@jamesbchao jamesbchao commented Aug 9, 2022 •
edited
Loading

Implemented the table view, which is a simple Fluent UI table view. Also created framework for obtaining the explanation on-the-fly for a single image by using a base64 encoded image of the explanation, generated and saved in the responsibleai_vision jupyter notebook. The rest of the flyout to be implemented in fixups/other PR's.

Known issues:
-changing the images to be obtained from mock data caused the thumbnail slider to break for the image list view
-error/success instances detection in flyout not implemented

Screenshot (33)

Screenshot (31)

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #1621 (3d6bc4c) into main (46e04a0) will increase coverage by 1.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
+ Coverage   88.97%   90.20%   +1.23%     
==========================================
  Files         111       39      -72     
  Lines        5453     1716    -3737     
==========================================
- Hits         4852     1548    -3304     
+ Misses        601      168     -433
Flag Coverage Δ
unittests 90.20% <ø> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onsibleai/responsibleai/serialization_utilities.py
.../responsibleai/_managers/counterfactual_manager.py
raiwidgets/raiwidgets/explanation_constants.py
...ponsibleai/responsibleai/_managers/base_manager.py
...eai/responsibleai/managers/data_balance_manager.py
...onsibleai/responsibleai/managers/causal_manager.py
...bleai/responsibleai/_tools/causal/causal_result.py
raiwidgets/raiwidgets/__init__.py
raiwidgets/raiwidgets/explanation_dashboard.py
...iwidgets/raiwidgets/fairness_metric_calculation.py
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-table-view branch from a84dee1 to 66b2df6 Compare August 9, 2022 05:22
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

3 similar comments
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

imatiach-msft
imatiach-msft approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments

libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.styles.ts Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.styles.ts Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.styles.ts Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.styles.ts Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.styles.ts Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TableList.tsx Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TableList.tsx Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx Outdated Show resolved Hide resolved
libs/localization/src/lib/en.json Outdated Show resolved Hide resolved
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-table-view branch from 4b45c1a to 3acabe4 Compare August 15, 2022 22:48
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-table-view branch from 3acabe4 to cb07225 Compare August 15, 2022 22:59
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-table-view branch from cb07225 to a80336a Compare August 15, 2022 23:51
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

vinuthakaranth
vinuthakaranth reviewed Aug 17, 2022
View reviewed changes
.vscode/settings.json Outdated
@@ -42,7 +42,7 @@
},
"[typescriptreact]": {
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode"
"editor.defaultFormatter": "rvest.vs-code-prettier-eslint"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know that changed stuff for anyone but me. I'll change it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesbchao can you change this back again? it looks like it is still there in latest commit

libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.tsx Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.tsx Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.tsx Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.tsx Outdated Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.styles.ts Show resolved Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.tsx Show resolved Hide resolved
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-table-view branch from a80336a to 864b816 Compare August 20, 2022 02:34
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-table-view/dashboard/index.html

@imatiach-msft imatiach-msft merged commit 4b15495 into main Aug 22, 2022
@imatiach-msft imatiach-msft deleted the jbchao/vision-dashboard-table-view branch August 22, 2022 22:30
@imatiach-msft imatiach-msft mentioned this pull request Sep 12, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongyu-microsoft tongyu-microsoft tongyu-microsoft left review comments

@RubyZ10 RubyZ10 RubyZ10 left review comments

@vinuthakaranth vinuthakaranth vinuthakaranth left review comments

@jameschao jameschao jameschao left review comments

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

@gaugup gaugup Awaiting requested review from gaugup gaugup is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jamesbchao @codecov-commenter @jameschao @imatiach-msft @vinuthakaranth @RubyZ10 @tongyu-microsoft