Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the time taken by RAIInsights counterfactual tests #1622

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 9, 2022

Description

It seems like the counterfactual tests in RAIInsights take significantly longer to run causing the run time of responsibleai tests to exceed an hour. The fix in this PR is limit the number of counterfactuals requested. After the fix the time taken by responsibleai tests has come down.

Build link before the fix:-
https://github.com/microsoft/responsible-ai-toolbox/runs/7751023879?check_suite_focus=true

Build link after the fix:-
https://github.com/microsoft/responsible-ai-toolbox/runs/7752977628?check_suite_focus=true

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #1622 (febc607) into main (6311e46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1622   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         105      105           
  Lines        5449     5449           
=======================================
  Hits         4842     4842           
  Misses        607      607           
Flag Coverage Δ
unittests 88.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) August 11, 2022 01:33
@gaugup gaugup merged commit 2d9f76f into main Aug 11, 2022
@gaugup gaugup deleted the gaugup/ReduceCFTestTime branch August 11, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants