Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'Classification outcome' cohort filter for multiclass scenario in SDK #1623

Merged
merged 6 commits into from
Aug 17, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 9, 2022

Description

It looks like we have "Classification Error" (aka "Classification outcome") filter supported for multiclass scenario. This was added as a part of the PR #1371. Hence, supporting the "Classification outcome" filter for multiclass case.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup requested a review from imatiach-msft as a code owner August 9, 2022 23:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #1623 (0ea7c09) into main (c16a093) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
- Coverage   89.03%   89.00%   -0.03%     
==========================================
  Files         105      105              
  Lines        5489     5502      +13     
==========================================
+ Hits         4887     4897      +10     
- Misses        602      605       +3     
Flag Coverage Δ
unittests 89.00% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ranalysis/erroranalysis/_internal/cohort_filter.py 86.74% <80.00%> (-0.84%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup changed the title Handle 'Classification outcome' cohort filter for multiclass scenario Handle 'Classification outcome' cohort filter for multiclass scenario in SDK Aug 9, 2022
@gaugup gaugup enabled auto-merge (squash) August 16, 2022 23:55
@gaugup gaugup merged commit f0f6c08 into main Aug 17, 2022
@gaugup gaugup deleted the gaugup/HandleClassificationOutcomeMulticlass branch August 17, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants