fix error analysis predictions analyzer failing due to new filtering refactor #1625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The simple scenario where only predictions and true labels are passed to error analysis dashboard is failing with the new released 0.3.7 version of erroranalysis package. This is due to the new filtering refactor, where model does not exist for the simple scenario, but we are still trying to access it. Supposedly our notebook tests should have caught this, but it seems because the dashboard python code is run on a separate thread the error doesn't actually lead to a notebook failure. This PR fixes the logic and adds additional unit tests for the both the predictions analyzer and model analyzer cases.
Checklist