Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identity feature value to counterfactual hover over #1626

Merged
merged 10 commits into from
Aug 12, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 10, 2022

Description

This PR adds the value in the identity feature column to the hover over in the counterfactual scatter plot chart.

Checklist

image

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

gaugup added 5 commits August 4, 2022 14:40
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
libs/core-ui/src/lib/util/JointDataset.ts Outdated Show resolved Hide resolved
libs/counterfactuals/src/lib/CounterfactualChart.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #1626 (71e491f) into main (84896f8) will decrease coverage by 3.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
- Coverage   89.01%   85.58%   -3.43%     
==========================================
  Files         105       58      -47     
  Lines        5489     2977    -2512     
==========================================
- Hits         4886     2548    -2338     
+ Misses        603      429     -174     
Flag Coverage Δ
unittests 85.58% <ø> (-3.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bleai/responsibleai/_tools/causal/causal_result.py
...i/responsibleai/managers/counterfactual_manager.py
responsibleai/responsibleai/_internal/__init__.py
...eai/responsibleai/databalanceanalysis/constants.py
responsibleai/responsibleai/_tools/__init__.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
responsibleai/responsibleai/_config/__init__.py
...ponsibleai/responsibleai/rai_insights/constants.py
...onsibleai/_tools/shared/attribute_serialization.py
responsibleai/responsibleai/exceptions.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup added 4 commits August 11, 2022 13:08
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup merged commit 7a94840 into main Aug 12, 2022
@gaugup gaugup deleted the gaugup/UIChangeFeatureMetadata branch August 12, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants