[Accessibility] fix several accessibility bugs #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
RubyZ10
requested review from
romanlutz,
xuke444,
tongyu-microsoft,
vinuthakaranth and
imatiach-msft
as code owners
RubyZ10
commented
Aug 11, 2022
libs/error-analysis/src/lib/ErrorAnalysisDashboard/Controls/TreeViewRenderer/TreeViewNode.tsx
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
+ Coverage 89.01% 90.33% +1.31%
==========================================
Files 105 39 -66
Lines 5489 1676 -3813
==========================================
- Hits 4886 1514 -3372
+ Misses 603 162 -441
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2 similar comments
libs/error-analysis/src/lib/ErrorAnalysisDashboard/Controls/TreeViewRenderer/TreeViewNode.tsx
Show resolved
Hide resolved
imatiach-msft
approved these changes
Aug 12, 2022
vinuthakaranth
approved these changes
Aug 12, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruby Zhu zhenzhu@microsoft.com
Description
This PR fix below bugs
Bug 1919764: A11yUsable - Feature importance - mouse centric language
Before change:
After change:
Task 1919020: 3. Bubble state colors & outline
Before change:
After change:
Task 1919029: 4. Feature/Value pill
Before change:
After change
Task 1925557: Error analysis tree keyboard accessible
Before:
the error analysis tree is not keyboard accessible, when navigating with tab, it pass the tree, goes to Model overview directly
After:
Bug 1919759: A11yMAS - [Keyboard accessible]Add component dialog on dashboard isn't keyboard accessible
Before change:
after the add component callout is open, click on tab, it goes to model overview, instead of opening the componet seletion
After change:
Task 1923223: Error analysis screen reader
Checklist