Minor refactoring in counterfactual package #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
tongyu-microsoft,
romanlutz,
vinuthakaranth,
xuke444 and
RubyZ10
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
- Coverage 89.01% 85.58% -3.43%
==========================================
Files 105 58 -47
Lines 5489 2977 -2512
==========================================
- Hits 4886 2548 -2338
+ Misses 603 429 -174
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tongyu-microsoft
approved these changes
Aug 12, 2022
1 similar comment
gaugup
added a commit
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
added a commit
that referenced
this pull request
Aug 16, 2022
* Add identity feature value to causal hover over Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint errors Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Minor refactoring in counterfactual package (#1634) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add identity feature value to feature importance hover over (#1637) * Add identity feature value to feature importance hover over Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix bug Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix code review comments Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Lint fix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * add UI tests for RAI text dashboard (#1636) * Fix code review comments Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * lint fix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Co-authored-by: Ilya Matiach <ilmat@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the file "getCounterfactualChartOptions" to utils as it looks like, all get functions are co-located in utils folder.
Checklist