Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'Regression Error' cohort filter for regression scenario in SDK #1644

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 16, 2022

Description

It seems we don't handle the "Error" (aka Regression Error) cohort filter in erroranalysis SDK. This PR adds this capability and the relevant test.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup requested a review from imatiach-msft as a code owner August 16, 2022 19:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #1644 (b9da56a) into main (f0f6c08) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
- Coverage   89.00%   89.00%   -0.01%     
==========================================
  Files         105      105              
  Lines        5502     5529      +27     
==========================================
+ Hits         4897     4921      +24     
- Misses        605      608       +3     
Flag Coverage Δ
unittests 89.00% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ranalysis/erroranalysis/_internal/cohort_filter.py 87.04% <88.88%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you also bump up version of erroranalysis so we can release this right away?

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup enabled auto-merge (squash) August 17, 2022 17:32
@gaugup gaugup merged commit 8d7aadc into main Aug 17, 2022
@gaugup gaugup deleted the gaugup/HandleRegressionError branch August 17, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants