Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing RAI Insights test due to change in EA _string_ind_data type #1658

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Fix failing RAI Insights test due to change in EA _string_ind_data type.
_string_ind_data used to be inconsistently either list or numpy array which was fixed in recent PR #1617 , however the test in RAIInsights test_rai_insights.py file is incorrectly validating the type is list.
This test started failing in gated build after the release of erroranalysis 0.3.9 to pypi.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #1658 (32c11fd) into main (fa41718) will decrease coverage by 3.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
- Coverage   89.00%   85.61%   -3.39%     
==========================================
  Files         105       58      -47     
  Lines        5529     3017    -2512     
==========================================
- Hits         4921     2583    -2338     
+ Misses        608      434     -174     
Flag Coverage Δ
unittests 85.61% <ø> (-3.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ai/responsibleai/_tools/error_analysis/__init__.py
responsibleai/responsibleai/_tools/__init__.py
.../responsibleai/modelanalysis/constants/__init__.py
...ponsibleai/responsibleai/_tools/shared/versions.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
responsibleai/responsibleai/__version__.py
.../databalanceanalysis/aggregate_balance_measures.py
...ibleai/_tools/shared/state_directory_management.py
...sponsibleai/responsibleai/rai_insights/__init__.py
...tabalanceanalysis/distribution_balance_measures.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-failing-ea-test branch from 21ea9c1 to efe986f Compare August 19, 2022 19:05
@imatiach-msft imatiach-msft requested a review from gaugup August 19, 2022 19:07
1 similar comment
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-failing-ea-test branch from efe986f to 32c11fd Compare August 19, 2022 20:48
@gaugup gaugup merged commit b899faf into main Aug 19, 2022
@gaugup gaugup deleted the ilmat/fix-failing-ea-test branch August 19, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants