-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failing RAI Insights test due to change in EA _string_ind_data type #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
- Coverage 89.00% 85.61% -3.39%
==========================================
Files 105 58 -47
Lines 5529 3017 -2512
==========================================
- Hits 4921 2583 -2338
+ Misses 608 434 -174
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
reviewed
Aug 19, 2022
imatiach-msft
force-pushed
the
ilmat/fix-failing-ea-test
branch
from
August 19, 2022 19:05
21ea9c1
to
efe986f
Compare
1 similar comment
gaugup
reviewed
Aug 19, 2022
imatiach-msft
force-pushed
the
ilmat/fix-failing-ea-test
branch
from
August 19, 2022 20:48
efe986f
to
32c11fd
Compare
gaugup
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix failing RAI Insights test due to change in EA _string_ind_data type.
_string_ind_data used to be inconsistently either list or numpy array which was fixed in recent PR #1617 , however the test in RAIInsights test_rai_insights.py file is incorrectly validating the type is list.
This test started failing in gated build after the release of erroranalysis 0.3.9 to pypi.
Checklist