Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validations for heterogeneity_features in causal manager #1659

Merged
merged 5 commits into from
Aug 23, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 19, 2022

Description

It seems like this validation was missing.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup added 2 commits August 22, 2022 15:08
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #1659 (3fcf838) into main (4b15495) will increase coverage by 1.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1659      +/-   ##
==========================================
+ Coverage   89.03%   90.20%   +1.17%     
==========================================
  Files         105       39      -66     
  Lines        5529     1716    -3813     
==========================================
- Hits         4923     1548    -3375     
+ Misses        606      168     -438     
Flag Coverage Δ
unittests 90.20% <ø> (+1.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onsibleai/responsibleai/managers/causal_manager.py
.../databalanceanalysis/aggregate_balance_measures.py
responsibleai/responsibleai/_data_validations.py
raiwidgets/raiwidgets/error_handling.py
...leai/responsibleai/databalanceanalysis/__init__.py
...ibleai/responsibleai/managers/explainer_manager.py
...onsibleai/responsibleai/serialization_utilities.py
...sibleai/responsibleai/rai_insights/rai_insights.py
...sibleai/responsibleai/_tools/shared/base_result.py
...ponsibleai/responsibleai/_tools/shared/__init__.py
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup enabled auto-merge (squash) August 22, 2022 23:17
1 similar comment
@gaugup gaugup merged commit fb916fb into main Aug 23, 2022
@gaugup gaugup deleted the gaugup/AddValidationHetrogenityTests branch August 23, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants