Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validations for dashboard endpoints #1672

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 26, 2022

Description

Adding a simple validation for which end points should be present in the widget to serve the dashboard.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #1672 (850d3c5) into main (6469f8b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1672   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         105      105           
  Lines        5553     5553           
=======================================
  Hits         4936     4936           
  Misses        617      617           
Flag Coverage Δ
unittests 88.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) August 30, 2022 17:19
@gaugup gaugup merged commit 0e3c9fc into main Aug 31, 2022
@gaugup gaugup deleted the gaugup/AddValidationsForDashboardEndPoints branch August 31, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants