-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON serialize the endpoint output and add tests #1679
Conversation
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #1679 +/- ##
==========================================
+ Coverage 85.37% 88.91% +3.54%
==========================================
Files 58 105 +47
Lines 3036 5559 +2523
==========================================
+ Hits 2592 4943 +2351
- Misses 444 616 +172
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved but can you change code owners so I'm not mandatory?
Description
It seems like the end point output should be serializable by JSON. This PR does the object serialization via
serialize_json_safe
and adds a test to make sure that the end point output is JSON serialized.Checklist