Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON serialize the endpoint output and add tests #1679

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 31, 2022

Description

It seems like the end point output should be serializable by JSON. This PR does the object serialization via serialize_json_safe and adds a test to make sure that the end point output is JSON serialized.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

gaugup added 2 commits August 31, 2022 15:29
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #1679 (3aa6975) into main (10963da) will increase coverage by 3.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
+ Coverage   85.37%   88.91%   +3.54%     
==========================================
  Files          58      105      +47     
  Lines        3036     5559    +2523     
==========================================
+ Hits         2592     4943    +2351     
- Misses        444      616     +172     
Flag Coverage Δ
unittests 88.91% <ø> (+3.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/responsibleai_dashboard.py 62.50% <ø> (ø)
...leai/responsibleai/modelanalysis/model_analysis.py 94.33% <0.00%> (ø)
...sibleai/responsibleai/rai_insights/rai_insights.py 76.72% <0.00%> (ø)
responsibleai/responsibleai/exceptions.py 100.00% <0.00%> (ø)
...sibleai/responsibleai/_tools/shared/base_result.py 95.65% <0.00%> (ø)
.../responsibleai/modelanalysis/constants/__init__.py 100.00% <0.00%> (ø)
...ponsibleai/responsibleai/_tools/causal/__init__.py 100.00% <0.00%> (ø)
...ibleai/_tools/causal/dashboard_schemas/__init__.py 100.00% <0.00%> (ø)
...ibleai/_tools/shared/state_directory_management.py 100.00% <0.00%> (ø)
...ai/responsibleai/_tools/causal/causal_constants.py 100.00% <0.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup changed the title JSON serialize the endpoint output and tests JSON serialize the endpoint output and add tests Sep 1, 2022
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but can you change code owners so I'm not mandatory?

@gaugup gaugup requested a review from RubyZ10 as a code owner September 8, 2022 17:33
@gaugup gaugup enabled auto-merge (squash) September 8, 2022 17:33
@gaugup gaugup merged commit 35747ad into main Sep 8, 2022
@gaugup gaugup deleted the gaugup/CheckForJSONserializationEndPointOutput branch September 8, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants