Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for RAI text dashboard, remove radio buttons and legend text when avg of abs value local importances selected #1683

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Sep 1, 2022

Description

For the RAI text dashboard, the radio buttons to select positive/negative/all importances are not relevant when the option "Average of absolute value" is selected for class importance weights. Hence, this PR removes those options to simplify the dashboard for users.

View of RAI text dashboard when "Average of absolute value" is selected:
image

View of RAI text dashboard when any class is selected:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #1683 (963de04) into main (0ebfb88) will increase coverage by 6.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
+ Coverage   78.93%   85.31%   +6.38%     
==========================================
  Files          19       58      +39     
  Lines        1315     3031    +1716     
==========================================
+ Hits         1038     2586    +1548     
- Misses        277      445     +168     
Flag Coverage Δ
unittests 85.31% <ø> (+6.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
erroranalysis/erroranalysis/_internal/constants.py 100.00% <0.00%> (ø)
raiutils/raiutils/webservice/__init__.py 100.00% <0.00%> (ø)
...core_flask/rai_core_flask/environments/__init__.py 100.00% <0.00%> (ø)
..._flask/environments/credentialed_vm_environment.py 100.00% <0.00%> (ø)
raiutils/raiutils/models/__init__.py 100.00% <0.00%> (ø)
rai_core_flask/rai_core_flask/__init__.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/_internal/metrics.py 89.47% <0.00%> (ø)
...ai_core_flask/environments/azure_nb_environment.py 73.52% <0.00%> (ø)
raiutils/raiutils/version.py 100.00% <0.00%> (ø)
...i_core_flask/environments/public_vm_environment.py 88.88% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft merged commit d1a6b50 into main Sep 7, 2022
@imatiach-msft imatiach-msft deleted the ilmat/rm-abs-radio-btn branch September 7, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants