Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'True Y' filter for cohort filtering #1685

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 1, 2022

Description

It seems the cohort filtering doesn't handle the cohort column name 'True Y'. The fix is to translate the value 'True Y' to 'true_y'. The added test covers this scenario.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #1685 (caa8408) into main (95c88b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         105      105           
  Lines        5557     5559    +2     
=======================================
+ Hits         4941     4943    +2     
  Misses        616      616           
Flag Coverage Δ
unittests 88.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ranalysis/erroranalysis/_internal/cohort_filter.py 87.17% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup requested a review from RubyZ10 as a code owner September 8, 2022 06:06
@gaugup gaugup enabled auto-merge (squash) September 8, 2022 15:40
@gaugup gaugup merged commit 10963da into main Sep 8, 2022
@gaugup gaugup deleted the gaugup/CohortFilterTrueYFix1 branch September 8, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants