Vision dashboard cohorts #1686
Merged
Vision dashboard cohorts #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbchao
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth,
romanlutz,
gaugup and
kicha0
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1686 +/- ##
===========================================
+ Coverage 78.93% 90.20% +11.27%
===========================================
Files 19 39 +20
Lines 1315 1716 +401
===========================================
+ Hits 1038 1548 +510
+ Misses 277 168 -109
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 tasks
imatiach-msft
approved these changes
Sep 6, 2022
apps/dashboard/src/interpret-vision/__mock_data__/visionData.ts
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/CohortToolBar.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Outdated
Show resolved
Hide resolved
jamesbchao
force-pushed
the
jbchao/vision-dashboard-cohorts
branch
from
3245f47 to
7ea4242
Compare
| @@ -51,6 +51,16 @@ const leftArrow: IIconProps = { | |||
| }; | |||
|
|
|||
| export class DataCharacteristicsRow extends React.Component<IDataCharacteristicsRowProps> { | |||
| /* | |||
There was a problem hiding this comment.
remove commented code
imatiach-msft
approved these changes
Sep 7, 2022
|
you can fix the remaining comment in next PR, let me merge this now since you have several follow-up PRs depending on this one |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI many of the file changes are just mock data
Adds cohort functionality to the vision dashboard, integrated with the model assessment cohorts. Build off of the model assessment PR. Enables users to:
Description
Checklist