Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision dashboard UI Fixups #1687

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Conversation

jamesbchao
Copy link
Contributor

Does not depend on any other open PRs

Fixups for the Vision dashboard UI to be consistent with latest Figma designs. Includes the following features:

  • flyout panel now shows item index, predicted y, true y, and external metadata
  • image list now shows both predicted and true labels
  • data characteristics label visibility selection moved to a dropdown
  • can choose between sorting by true labels and predicted labels in data characteristics

Screenshot (65)
Screenshot (66)
Screenshot (67)
Screenshot (68)
Screenshot (69)

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1687 (39feb6e) into main (9a566ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1687   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         105      105           
  Lines        5553     5553           
=======================================
  Hits         4937     4937           
  Misses        616      616           
Flag Coverage Δ
unittests 88.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments

@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-fixups branch from 9e0f987 to 0d09288 Compare September 6, 2022 19:39
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-fixups branch 2 times, most recently from 6e1f66e to ee967ae Compare September 7, 2022 23:24
@jamesbchao jamesbchao mentioned this pull request Sep 7, 2022
3 tasks
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-fixups branch 2 times, most recently from 6805687 to 3ecf6ba Compare September 7, 2022 23:35
Signed-off-by: James Chao <jbchao@stanford.edu>
@jamesbchao jamesbchao force-pushed the jbchao/vision-dashboard-fixups branch from 3ecf6ba to aa42f0a Compare September 7, 2022 23:35
7 similar comments
@imatiach-msft imatiach-msft merged commit 95c88b4 into main Sep 8, 2022
@imatiach-msft imatiach-msft deleted the jbchao/vision-dashboard-fixups branch September 8, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants