Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization for causal tooltips #1690

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 6, 2022

Description

It seems like the indirection using the causalCalloutDictionary was causing the localization to not happen. So removed that indirection and using the localization strings as is.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

image

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1690 (bc81304) into main (0ebfb88) will increase coverage by 9.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   78.93%   88.88%   +9.95%     
==========================================
  Files          19      105      +86     
  Lines        1315     5553    +4238     
==========================================
+ Hits         1038     4936    +3898     
- Misses        277      617     +340     
Flag Coverage Δ
unittests 88.88% <ø> (+9.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/exceptions.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/managers/__init__.py 100.00% <0.00%> (ø)
raiutils/raiutils/data_processing/__init__.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_internal/constants.py 100.00% <0.00%> (ø)
...bleai/responsibleai/_tools/causal/causal_result.py 97.05% <0.00%> (ø)
raiutils/raiutils/common/__init__.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/version.py 100.00% <0.00%> (ø)
...sponsibleai/responsibleai/managers/base_manager.py 95.23% <0.00%> (ø)
erroranalysis/erroranalysis/_internal/utils.py 84.61% <0.00%> (ø)
erroranalysis/erroranalysis/__init__.py 100.00% <0.00%> (ø)
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup enabled auto-merge (squash) September 6, 2022 18:09
@gaugup gaugup merged commit 6d99729 into main Sep 6, 2022
@gaugup gaugup deleted the gaugup/FixCausalLocalization branch September 6, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants