Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid additional predict call in case of ModelAnalyzer #1701

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 9, 2022

Description

Looks like in case the model is present in erroranalysis, we are doing an additional predict() call. This is ok for small datasets but for large datasets every predict call adds sometime to response time. Hence, removing the additional predict call.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #1701 (58986b4) into main (a7cb025) will increase coverage by 1.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   88.91%   90.39%   +1.47%     
==========================================
  Files         105       39      -66     
  Lines        5559     1718    -3841     
==========================================
- Hits         4943     1553    -3390     
+ Misses        616      165     -451     
Flag Coverage Δ
unittests 90.39% <100.00%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ranalysis/erroranalysis/_internal/matrix_filter.py 96.64% <100.00%> (+0.79%) ⬆️
raiwidgets/raiwidgets/interfaces.py
...ponsibleai/responsibleai/_tools/causal/__init__.py
...ponsibleai/responsibleai/_tools/shared/versions.py
...ai/responsibleai/rai_insights/rai_base_insights.py
.../databalanceanalysis/aggregate_balance_measures.py
raiwidgets/raiwidgets/cohort.py
responsibleai/responsibleai/_data_validations.py
raiwidgets/raiwidgets/__init__.py
...tabalanceanalysis/distribution_balance_measures.py
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) September 12, 2022 15:32
@gaugup gaugup merged commit 4d54e07 into main Sep 12, 2022
@gaugup gaugup deleted the gaugup/AvoidAdditionalPredictCall branch September 12, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants