Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme-enhancements #1704

Merged
merged 7 commits into from
Sep 26, 2022
Merged

readme-enhancements #1704

merged 7 commits into from
Sep 26, 2022

Conversation

mesameki
Copy link
Contributor

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #1704 (f11dc2a) into main (0451264) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1704   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          90       90           
  Lines        5252     5252           
=======================================
  Hits         4638     4638           
  Misses        614      614           
Flag Coverage Δ
unittests 88.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
README.md Outdated Show resolved Hide resolved
3 similar comments
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking through history, this indeed won't work, see the PR:
#1010
I changed the paths to be absolute then instead of relative for the pypi page (raiwidgets · PyPI) and this PR will break that once again

@mesameki mesameki force-pushed the mesameki/readme-enhance branch from fd909fe to f11dc2a Compare September 26, 2022 15:55
1 similar comment
@imatiach-msft imatiach-msft merged commit 83607eb into main Sep 26, 2022
@imatiach-msft imatiach-msft deleted the mesameki/readme-enhance branch September 26, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants