clean up dataset explorer #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ke Xu <xuke@microsoft.com>
xuke444
requested review from
imatiach-msft,
tongyu-microsoft,
RubyZ10,
vinuthakaranth,
romanlutz and
gaugup
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1721 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 105 105
Lines 5577 5577
=======================================
Hits 4964 4964
Misses 613 613
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| this.setState({ chartProps: newProps }); | ||
| this.logButtonClick(TelemetryEventName.DatasetExplorerNewChartTypeSelected); | ||
| }; | ||
|
|
||
| private logButtonClick = (eventName: TelemetryEventName): void => { | ||
| this.props.telemetryHook?.({ |
There was a problem hiding this comment.
Do we want to update all props.telemetryHook to context.telemetryHook? For example this line?
There was a problem hiding this comment.
I am planning to wrap all buttons/input etc for automatically telemetry.
tongyu-microsoft
approved these changes
Sep 15, 2022
Signed-off-by: Ke Xu <xuke@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up dataset explorer by reduce file size
use context in axis config instead of passing values