Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y]Show Error analysis tree focus && Add Screen reader for 1. New cohort panel, 2. Add component callout 3. Callout tooltip #1727

Merged
merged 14 commits into from
Sep 21, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Sep 16, 2022

Description

  1. Add Error analysis tree focus
    image
  2. for New cohort panel, after clicking on clear all filters, announce "no filters applied", after click on Add filter, announce, "filter added"
  3. Add screen reader for add component callout
  4. Update InfoCallout to support screen reader, this affect all places(basically all the tooltips) leverage InfoCallout

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

RubyZ10 and others added 6 commits September 14, 2022 14:00
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #1727 (8c84e51) into main (c86bfff) will increase coverage by 10.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1727       +/-   ##
===========================================
+ Coverage   78.95%   88.99%   +10.04%     
===========================================
  Files          19      105       +86     
  Lines        1321     5589     +4268     
===========================================
+ Hits         1043     4974     +3931     
- Misses        278      615      +337     
Flag Coverage Δ
unittests 88.99% <ø> (+10.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
erroranalysis/erroranalysis/_internal/utils.py 84.61% <0.00%> (ø)
...i_core_flask/environments/public_vm_environment.py 88.88% <0.00%> (ø)
...ponsibleai/responsibleai/_tools/shared/versions.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_config/base_config.py 92.30% <0.00%> (ø)
...ponsibleai/responsibleai/rai_insights/constants.py 100.00% <0.00%> (ø)
raiutils/raiutils/webservice/__init__.py 100.00% <0.00%> (ø)
...leai/responsibleai/modelanalysis/model_analysis.py 94.33% <0.00%> (ø)
..._core_flask/rai_core_flask/environment_detector.py 53.33% <0.00%> (ø)
...eai/responsibleai/databalanceanalysis/constants.py 100.00% <0.00%> (ø)
...nalysis/erroranalysis/_internal/version_checker.py 50.00% <0.00%> (ø)
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@RubyZ10 RubyZ10 enabled auto-merge (squash) September 20, 2022 23:40
@RubyZ10 RubyZ10 merged commit 011862e into main Sep 21, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/accessibility branch September 21, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants