Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RAI dashboard for vision models crashing when selecting individual datapoints in data analysis #1733

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Fix RAI dashboard for vision models crashing when selecting individual datapoints in data analysis.

This PR refactors the UI backend code to handle tabular, image and text multiclass scenarios more consistently with a helper method IsMulticlass. We were previously only doing certain transformations for multiclass tabular case which was causing the crash to appear.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #1733 (5dd6fcf) into main (a155b05) will increase coverage by 14.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1733       +/-   ##
===========================================
+ Coverage   75.72%   89.85%   +14.12%     
===========================================
  Files          16       32       +16     
  Lines        1141     1626      +485     
===========================================
+ Hits          864     1461      +597     
+ Misses        277      165      -112     
Flag Coverage Δ
unittests 89.85% <ø> (+14.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/error_handling.py
...iwidgets/raiwidgets/explanation_dashboard_input.py
raiwidgets/raiwidgets/responsibleai_dashboard.py
...dgets/raiwidgets/error_analysis_dashboard_input.py
raiwidgets/raiwidgets/model_analysis_dashboard.py
raiwidgets/raiwidgets/explanation_dashboard.py
...iwidgets/raiwidgets/fairness_metric_calculation.py
...idgets/raiwidgets/responsibleai_dashboard_input.py
raiwidgets/raiwidgets/error_analysis_constants.py
raiwidgets/raiwidgets/dashboard.py
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-instances-err branch from a86e28c to 9e59d23 Compare September 20, 2022 19:14
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-instances-err branch from 9e59d23 to 5dd6fcf Compare September 27, 2022 02:28
@imatiach-msft imatiach-msft merged commit 7ba1f3e into main Sep 27, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-instances-err branch September 27, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants