-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flaky test test_rai_insights_add_save_load_save on dataset fetch #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth and
tongyu-microsoft
as code owners
September 20, 2022 16:56
imatiach-msft
force-pushed
the
ilmat/fix-test-err
branch
from
September 20, 2022 17:00
782403f
to
42d1f06
Compare
Codecov Report
@@ Coverage Diff @@
## main #1734 +/- ##
===========================================
+ Coverage 78.95% 88.99% +10.04%
===========================================
Files 19 105 +86
Lines 1321 5589 +4268
===========================================
+ Hits 1043 4974 +3931
- Misses 278 615 +337
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
imatiach-msft
force-pushed
the
ilmat/fix-test-err
branch
from
September 20, 2022 17:07
42d1f06
to
e9e5299
Compare
gaugup
reviewed
Sep 20, 2022
imatiach-msft
force-pushed
the
ilmat/fix-test-err
branch
from
September 20, 2022 17:17
e9e5299
to
c927f26
Compare
3 similar comments
imatiach-msft
force-pushed
the
ilmat/fix-test-err
branch
from
September 20, 2022 19:13
c927f26
to
27bec0a
Compare
gaugup
approved these changes
Sep 26, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test test_rai_insights_add_save_load_save is flaky has been erroring including on the build:
https://github.com/microsoft/responsible-ai-toolbox/actions/runs/3087387703/jobs/4992705136
The underlying error was a networking issue:
Adding simple retry logic around it via raiutils retry_function method makes the test more reliable.
Checklist