Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test test_rai_insights_add_save_load_save on dataset fetch #1734

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

The test test_rai_insights_add_save_load_save is flaky has been erroring including on the build:

https://github.com/microsoft/responsible-ai-toolbox/actions/runs/3087387703/jobs/4992705136

The underlying error was a networking issue:

>           raise FileNotFoundError(f"{path} not found.")
E           FileNotFoundError: https://archive.ics.uci.edu/ml/machine-learning-databases/adult/adult.data not found.

Adding simple retry logic around it via raiutils retry_function method makes the test more reliable.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #1734 (27bec0a) into main (c86bfff) will increase coverage by 10.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1734       +/-   ##
===========================================
+ Coverage   78.95%   88.99%   +10.04%     
===========================================
  Files          19      105       +86     
  Lines        1321     5589     +4268     
===========================================
+ Hits         1043     4974     +3931     
- Misses        278      615      +337     
Flag Coverage Δ
unittests 88.99% <ø> (+10.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ranalysis/erroranalysis/_internal/cohort_filter.py 87.17% <0.00%> (ø)
raiutils/raiutils/dataset/__init__.py 100.00% <0.00%> (ø)
...i/responsibleai/managers/error_analysis_manager.py 88.88% <0.00%> (ø)
...ai_core_flask/environments/azure_nb_environment.py 73.52% <0.00%> (ø)
...sponsibleai/responsibleai/managers/base_manager.py 95.23% <0.00%> (ø)
...nsibleai/databalanceanalysis/data_balance_utils.py 100.00% <0.00%> (ø)
...bleai/responsibleai/_tools/causal/causal_result.py 97.05% <0.00%> (ø)
erroranalysis/erroranalysis/report/error_report.py 94.04% <0.00%> (ø)
...sponsibleai/responsibleai/rai_insights/__init__.py 100.00% <0.00%> (ø)
...nalysis/erroranalysis/_internal/version_checker.py 50.00% <0.00%> (ø)
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

responsibleai/tests/common_utils.py Outdated Show resolved Hide resolved
responsibleai/tests/common_utils.py Outdated Show resolved Hide resolved
3 similar comments
@imatiach-msft imatiach-msft merged commit e574ec3 into main Sep 26, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-test-err branch September 26, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants