Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Fix bug - Screen reader is not announcing the associated information with axis selection radio buttons in data analysis chart view #1736

Merged
merged 6 commits into from
Sep 21, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Sep 20, 2022

Description

Announce associated information for axis selection radio button
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@RubyZ10 RubyZ10 changed the title [A11y] Fix bug - Screen reader is not announcing the associated information with radio buttons after selecting radio button under "positive_worlds" flyout. [A11y] Fix bug - Screen reader is not announcing the associated information with axis selection radio buttons in data analysis chart view Sep 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #1736 (487d9f2) into main (011862e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1736   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files         105      105           
  Lines        5589     5589           
=======================================
  Hits         4974     4974           
  Misses        615      615           
Flag Coverage Δ
unittests 88.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@RubyZ10 RubyZ10 enabled auto-merge (squash) September 21, 2022 16:28
@RubyZ10 RubyZ10 merged commit 1d526b3 into main Sep 21, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/A11y branch September 21, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants