-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y] Fix bug - Screen reader is not announcing the associated information with axis selection radio buttons in data analysis chart view #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
RubyZ10
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
vinuthakaranth and
romanlutz
as code owners
September 20, 2022 22:30
RubyZ10
changed the title
[A11y] Fix bug - Screen reader is not announcing the associated information with radio buttons after selecting radio button under "positive_worlds" flyout.
[A11y] Fix bug - Screen reader is not announcing the associated information with axis selection radio buttons in data analysis chart view
Sep 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #1736 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 105 105
Lines 5589 5589
=======================================
Hits 4974 4974
Misses 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tongyu-microsoft
approved these changes
Sep 20, 2022
1 similar comment
imatiach-msft
approved these changes
Sep 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Announce associated information for axis selection radio button
Checklist