Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data characteristics search and fix switching between tabs in RAI vision dashboard #1745

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Sep 26, 2022

Description

This PR implements the logic so that the search bar in the data characteristics tab works (filters images/instances). Also, the PR fixes switching tabs from image explorer view to table view and data characteristics, such that the items are filtered in all view, and refactors some of the code to remove duplication.

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #1745 (ca5bab1) into main (0451264) will increase coverage by 1.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
+ Coverage   88.30%   89.85%   +1.54%     
==========================================
  Files          90       32      -58     
  Lines        5252     1626    -3626     
==========================================
- Hits         4638     1461    -3177     
+ Misses        614      165     -449     
Flag Coverage Δ
unittests 89.85% <ø> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sponsibleai/responsibleai/rai_insights/__init__.py
...i/responsibleai/managers/error_analysis_manager.py
...dgets/raiwidgets/error_analysis_dashboard_input.py
...sibleai/responsibleai/_tools/shared/base_result.py
responsibleai/responsibleai/_config/__init__.py
...sponsibleai/responsibleai/managers/base_manager.py
raiwidgets/raiwidgets/responsibleai_dashboard.py
...bleai/responsibleai/_tools/causal/causal_config.py
...ai/responsibleai/_tools/causal/causal_constants.py
...ibleai/_tools/causal/dashboard_schemas/__init__.py
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-data-char-search branch from c7aad6f to ca5bab1 Compare September 26, 2022 16:01
@imatiach-msft imatiach-msft merged commit fb54500 into main Sep 26, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-data-char-search branch September 26, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants