Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate settings button in RAI dashboard for images #1747

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Remove duplicate settings button in RAI dashboard for images.
The settings button is a duplicate of the settings button at the top of the dashboard.

Before changes:
image

After changes:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #1747 (6b785c8) into main (7ba1f3e) will increase coverage by 1.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
+ Coverage   88.30%   89.85%   +1.54%     
==========================================
  Files          90       32      -58     
  Lines        5252     1626    -3626     
==========================================
- Hits         4638     1461    -3177     
+ Misses        614      165     -449     
Flag Coverage Δ
unittests 89.85% <ø> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/error_handling.py
...ponsibleai/responsibleai/_tools/shared/versions.py
...ibleai/_tools/shared/state_directory_management.py
...i/responsibleai/managers/counterfactual_manager.py
raiwidgets/raiwidgets/fairness_dashboard.py
...onsibleai/_tools/shared/attribute_serialization.py
...tools/error_analysis/dashboard_schemas/__init__.py
...i/responsibleai/managers/error_analysis_manager.py
...ai/responsibleai/_tools/counterfactual/__init__.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft merged commit fb550e2 into main Sep 27, 2022
@imatiach-msft imatiach-msft deleted the ilmat/rm-settings-button branch September 27, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants