Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validations to catch empty train/test scenarios #1749

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 27, 2022

Description

Adding these validations to make sure the downstream predict calls don't fail unexpectedly.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #1749 (aaf4c97) into main (2050f20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1749   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          32       32           
  Lines        1626     1626           
=======================================
  Hits         1461     1461           
  Misses        165      165           
Flag Coverage Δ
unittests 89.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@gaugup gaugup enabled auto-merge (squash) September 27, 2022 19:04
@gaugup gaugup merged commit 3c7368c into main Sep 27, 2022
@gaugup gaugup deleted the gaugup/AddEmptyDataValidations branch September 27, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants