Fix full name not visible for features in highcharts #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
…olbox into vikarant/chartRefreshFixDep
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
…olbox into vikarant/chartRefreshFixDep
vinuthakaranth
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
RubyZ10,
romanlutz and
gaugup
as code owners
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
xuke444
approved these changes
Oct 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #1761 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 89 89
Lines 5250 5250
=======================================
Hits 4636 4636
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
approved these changes
Oct 3, 2022
imatiach-msft
approved these changes
Oct 3, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix full name not visible for features in highcharts.
After adding textOverflow: "ellipsis" in the default highchart options, when feature name overflows, it will display as below in pop-up on hover. This is consistent in behavior with officeui.
featureNames is used now instead of featureNamesAbridged which truncates the featureNames to length of 18 chars.
Checklist