Filter out undefined filters to resolve a robot page exception #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongyu-microsoft
requested review from
imatiach-msft,
xuke444,
RubyZ10,
vinuthakaranth and
romanlutz
as code owners
|
Can we add a unit test for this change? |
Tests are added |
Codecov Report
@@ Coverage Diff @@
## main #1764 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 89 89
Lines 5250 5250
=======================================
Hits 4636 4636
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
vinuthakaranth
approved these changes
Oct 5, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a robot page exception due to
TypeError: Cannot read properties of undefined (reading 'column') at t.setFilterLabel (https://ml.azure.com/static/js/79.5338ded6.chunk.js:2:1874569) at https://ml.azure.com/static/js/79.5338ded6.chunk.js:2:1874007 at Array.map (<anonymous>)This PR filters out cohort filters if the filter is undefined so we can make sure user won't hit robot page exception for this issue.
Description
For this.props.filters
Before: [filterA, filterB, undefined]
After: [filterA, filterB]
Checklist