fix error analysis cohort filter for string label values #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
RubyZ10,
vinuthakaranth and
tongyu-microsoft
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
==========================================
+ Coverage 88.30% 91.81% +3.51%
==========================================
Files 89 73 -16
Lines 5250 4118 -1132
==========================================
- Hits 4636 3781 -855
+ Misses 614 337 -277
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
imatiach-msft
force-pushed
the
ilmat/fix-cohort-filter
branch
2 times, most recently
from
fa7e498 to
4e06d9e
Compare
1 similar comment
gaugup
reviewed
Oct 6, 2022
imatiach-msft
force-pushed
the
ilmat/fix-cohort-filter
branch
from
4e06d9e to
794ce37
Compare
gaugup
approved these changes
Oct 6, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the cohort filter to support string label values. Otherwise, when creating a filter based on "True Y" or "Predicted Y", and changing the base cohort, error analysis can fail to filter the data correctly because the filter from UI is in terms of indexes while the data itself has string values.
Checklist