Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependency and method in nlp-feature-extractors package #1823

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

remove unused dependency and method in nlp-feature-extractors package

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #1823 (0e24112) into main (5fe8a91) will decrease coverage by 5.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1823      +/-   ##
==========================================
- Coverage   88.54%   82.80%   -5.74%     
==========================================
  Files          96       55      -41     
  Lines        5481     2926    -2555     
==========================================
- Hits         4853     2423    -2430     
+ Misses        628      503     -125     
Flag Coverage Δ
unittests 82.80% <ø> (-5.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/_data_validations.py
responsibleai/responsibleai/_tools/__init__.py
...ponsibleai/responsibleai/_tools/shared/__init__.py
...nsibleai/databalanceanalysis/data_balance_utils.py
responsibleai/responsibleai/_interfaces.py
...sponsibleai/responsibleai/managers/base_manager.py
...ai/databalanceanalysis/feature_balance_measures.py
...ai/responsibleai/_tools/causal/causal_constants.py
...tools/counterfactual/dashboard_schemas/__init__.py
...ibleai/_tools/shared/state_directory_management.py
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this, Ilya!

@imatiach-msft imatiach-msft merged commit 2de81d5 into main Nov 30, 2022
@imatiach-msft imatiach-msft deleted the ilmat/remove-nlp-dep branch November 30, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants