Use "lower whisker" and "upper whisker" instead of misleading "minimum" and "maximum" on boxplot tooltips #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
gaugup
approved these changes
Dec 2, 2022
…olbox into romanlutz/boxplot_tooltips
imatiach-msft
approved these changes
Dec 2, 2022
1 similar comment
vinuthakaranth
approved these changes
Dec 2, 2022
xuke444
reviewed
Dec 2, 2022
.../src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ProbabilityDistributionBoxChart.tsx
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1825 +/- ##
===========================================
- Coverage 88.54% 76.32% -12.22%
===========================================
Files 96 26 -70
Lines 5490 528 -4962
===========================================
- Hits 4861 403 -4458
+ Misses 629 125 -504
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…olbox into romanlutz/boxplot_tooltips
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a fairly lengthy (but nevertheless interesting!) discussion about boxplot tooltip labels back in April I got the task assigned to fix it. Rereading the thread today it seemed like "lower whisker" and "upper whisker" were preferred.
As this is the tooltip of the
series, not the overall chart, I didn't find a way to make it just the default option, but rather added it to the three existing box plots in the dataset explorer, model overview, and feature importance components.model overview
dataset explorer
feature importance:
Checklist