Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to prediction wrappers from ml-wrappers #1830

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Dec 5, 2022

Description

The Prediction wrappers (https://github.com/microsoft/ml-wrappers/blob/main/python/ml_wrappers/model/predictions_wrapper.py) were introduced in 0.3.0 release in ml-wrappers. Hence, removing the code in raiwidgets tests and referring the prediction wrappers from ml-wrappers.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@romanlutz romanlutz changed the title Refer prediction wrappers from ml-wrappers Refer to prediction wrappers from ml-wrappers Dec 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #1830 (e7b72a5) into main (5343666) will decrease coverage by 2.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
- Coverage   93.35%   90.64%   -2.72%     
==========================================
  Files          93       46      -47     
  Lines        4574     1881    -2693     
==========================================
- Hits         4270     1705    -2565     
+ Misses        304      176     -128     
Flag Coverage Δ
unittests 90.64% <ø> (-2.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/feature_metadata.py
...ai/databalanceanalysis/feature_balance_measures.py
responsibleai/responsibleai/_tools/__init__.py
...i/responsibleai/managers/error_analysis_manager.py
...bleai/responsibleai/_tools/causal/causal_config.py
...ponsibleai/responsibleai/_tools/shared/versions.py
responsibleai/responsibleai/_config/base_config.py
responsibleai/responsibleai/_internal/__init__.py
...sponsibleai/responsibleai/managers/base_manager.py
...leai/responsibleai/databalanceanalysis/__init__.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) January 9, 2023 18:42
@gaugup gaugup merged commit 8730515 into main Jan 9, 2023
@gaugup gaugup deleted the gaugup/UpdatePredcitionWrappers branch January 9, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants