upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error #1838

imatiach-msft · 2022-12-08T22:14:56Z

Description

We are seeing build errors on main related to the setup-python github action for python 3.6.
This PR tries to:

1.) Upgrade setup-python github action from v2 to latest version v4
2.) Based on issues, error seems to occur when using python 3.6 with new latest-ubuntu OS tag. Hence, pinning to older ubuntu for python 3.6 in test matrix resolves this.

Related issue:
actions/setup-python#544
actions/setup-python#543

Checklist

I have added screenshots above for all UI changes.
I have added e2e tests for all UI changes.
Documentation was updated if it was needed.

codecov-commenter · 2022-12-08T22:48:39Z

Codecov Report

Merging #1838 (033bb73) into main (d89b03a) will increase coverage by 5.15%.
The diff coverage is n/a.

❗ Current head 033bb73 differs from pull request most recent head 51a4345. Consider uploading reports for the commit 51a4345 to get more accurate results

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   73.84%   79.00%   +5.15%     
==========================================
  Files          25       19       -6     
  Lines        1277     1324      +47     
==========================================
+ Hits          943     1046     +103     
+ Misses        334      278      -56

Flag	Coverage Δ
unittests	`79.00% <ø> (+5.15%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
..._test_utils/datasets/tabular/tabular_data_utils.py
...t_utils/rai_test_utils/models/lightgbm/__init__.py
...test_utils/models/lightgbm/lightgbm_model_utils.py
rai_test_utils/rai_test_utils/datasets/__init__.py
..._utils/rai_test_utils/datasets/tabular/__init__.py
...i_test_utils/models/sklearn/sklearn_model_utils.py
...i_test_utils/models/xgboost/xgboost_model_utils.py
...st_utils/rai_test_utils/models/sklearn/__init__.py
...st_utils/rai_test_utils/models/xgboost/__init__.py
raiwidgets/raiwidgets/__init__.py	`100.00% <0.00%> (ø)`
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-12-08T22:56:26Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

github-actions · 2022-12-09T00:11:43Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

github-actions · 2022-12-09T00:16:33Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

github-actions · 2022-12-09T01:33:11Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

github-actions · 2022-12-09T02:26:24Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

github-actions · 2022-12-09T05:19:50Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

…ntu image for python 3.6 to fix build error

github-actions · 2022-12-09T05:25:41Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

github-actions · 2022-12-09T05:33:35Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

github-actions · 2022-12-09T06:00:28Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-setup-python/dashboard/index.html

The `ubuntu-latest` platform for GitHub Actions CI recently updated to Ubuntu 22.04 (see actions/runner-images#6399) and dropped support for Python 3.6 (actions/setup-python#544 (comment)) As inspired by this workaround (microsoft/responsible-ai-toolbox#1838), use Ubuntu 20.04 only for Python 3.6 testing.

…ntu image for python 3.6 to fix build error (#1838)

* Add missing property 'id' in ICounterfactualData Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Update some sample notebooks to include dropped_features (#1836) * update some notebooks to include dropped_features * update some notebooks to include dropped_features * update some notebooks to include dropped_features * remove unused changes * remove unused changes * address comments * upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error (#1838) * Gate call to probability distribution end point (#1839) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Revert "Update some sample notebooks to include dropped_features (#1836)" (#1837) This reverts commit d89b03a. * fix cf error on unable to update text (#1842) * Disable partial dependence plots for large data scenarios (#1843) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Remove redundant call to serialize_json_safe() in raiwidgets causal tests (#1840) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fetching global causal effects and global policy from SDK backend (#1753) * Add callback for global causal effects Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Query SDK backend to get global causal effects Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix bug in causal serialization Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Adding callback for causal ploicy Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * propagate global and local effects only Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add support for getting global causal effects from SDK backend Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * lint fix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix bug Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Modify the cohort message Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Move to state Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix imports Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Remove console.log Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Change the if condition Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add postga build trigger (#1755) (#1756) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add model wrapper for wrapping predictions and test data (#1762) * Add model wrapper for wrapping predictions and test data Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix failing tests Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Remove force update Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Update requirements-linting.txt (#1847) * Remove typo casual and correcting it to causal (#1846) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Disable local causal chart for large data support (#1845) * Disable local causal chart for large data support Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * add multilabel text example and fix correct and incorrect groups in data analysis (#1848) * Add number of cohort samples inside generateMetrics() (#1849) * Add number of cohort samples inside generateMetrics() Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Yarn lintfix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * add multilabel RAI vision example for fridge multilabel dataset (#1844) * fix install command for speech to text example (#1856) * Send the correct column name to SDK backend for model overview distribution charts (#1835) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Derive fairness metrics from metric stats instead of cohort stats (#1854) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * add upper bounds to greenlet and gevent in rai-core-flask as 5.0 release fails until they are more stable (#1852) * fix loading older versions of RAIInsights due to _FEATURE_METADATA key error (#1857) * Update maintainers (#1860) * Update requirements.txt in `raiwidgets` and `responsibleai` to pin numpy upper bound (#1864) * Update requirements.txt * Update requirements.txt * Port `cohort.py` from `raiwidgets` to `raiutils` (#1859) * Port cohort.py from raiwidgets to raiutils Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add more constants Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add constants.py Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Make constants public Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add common APIs for model overview metrics (#1862) * Add metric SDK APIs for Model Overview metrics Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * remove console.log() Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Port `cohort.py` from `raiwidgets` to `raiutils` (#1859) * Port cohort.py from raiwidgets to raiutils Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add more constants Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add constants.py Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Make constants public Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * lint fix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Update requirements-linting.txt (#1861) * update raiwidgets to rai-core-flask v0.5.0 (#1851) * fix error in erroranalysis heatmap caused by max value over right side of max bin (#1866) * remove dead space in aggregate feature importance (#1869) * display tree branching decisions (#1870) * Remove warning for 'dropped_features are not in use currently.' (#1871) * display tree branching decisions * Remove warning for 'dropped_features are not in use currently.' * turn off fail-fast for python tests (#1878) * add multilabel model overview metrics (#1882) * Show branching decisions on hover over on unselected tree nodes (#1881) * show tree label on hover over * address comments * Update some sample notebooks to include dropped_features (#1836) * update some notebooks to include dropped_features * update some notebooks to include dropped_features * update some notebooks to include dropped_features * remove unused changes * remove unused changes * address comments * Revert "Update some sample notebooks to include dropped_features (#1836)" (#1837) This reverts commit d89b03a. * Update requirements-linting.txt (#1847) * Add number of cohort samples inside generateMetrics() (#1849) * Add number of cohort samples inside generateMetrics() Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Yarn lintfix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Update requirements-linting.txt (#1861) * add multilabel model overview metrics (#1882) * Update `raiutils` in `raiwidgets`, `responsibleai`, `erroranalysis` and `nlp_feature_extractors` (#1873) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix test Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Undo changes Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix lint Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Co-authored-by: tongy-msft <91754176+tongyu-microsoft@users.noreply.github.com> Co-authored-by: Ilya Matiach <ilmat@microsoft.com> Co-authored-by: Roman Lutz <romanlutz13@gmail.com>

tongyu-microsoft approved these changes Dec 8, 2022

View reviewed changes

gaugup approved these changes Dec 9, 2022

View reviewed changes

imatiach-msft force-pushed the ilmat/upgrade-setup-python branch 3 times, most recently from fdc920d to 23718c4 Compare December 9, 2022 04:54

imatiach-msft changed the title ~~upgrade setup-python github action from v2 to v4 to fix python 3.6 build error~~ upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error Dec 9, 2022

upgrade setup-python github action from v2 to v4 and pin to older ubu…

51a4345

…ntu image for python 3.6 to fix build error

imatiach-msft force-pushed the ilmat/upgrade-setup-python branch from 23718c4 to 51a4345 Compare December 9, 2022 05:24

imatiach-msft merged commit 75e4926 into main Dec 9, 2022

imatiach-msft deleted the ilmat/upgrade-setup-python branch December 9, 2022 16:44

yoda-vid mentioned this pull request Dec 12, 2022

Run CI for Python 3.6 on Ubuntu 20.04 only sanderslab/magellanmapper#342

Merged

gaugup pushed a commit that referenced this pull request Jan 6, 2023

upgrade setup-python github action from v2 to v4 and pin to older ubu…

4bd9db1

…ntu image for python 3.6 to fix build error (#1838)

imatiach-msft mentioned this pull request Jan 6, 2023

release raiwidgets and responsibleai 0.24.0 #1891

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error #1838

upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error #1838

imatiach-msft commented Dec 8, 2022 •

edited

Loading

codecov-commenter commented Dec 8, 2022 •

edited

Loading

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error #1838

upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error #1838

Conversation

imatiach-msft commented Dec 8, 2022 • edited Loading

Description

Checklist

codecov-commenter commented Dec 8, 2022 • edited Loading

Codecov Report

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

imatiach-msft commented Dec 8, 2022 •

edited

Loading

codecov-commenter commented Dec 8, 2022 •

edited

Loading