Add better error message if all features are dropped from dataset #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongyu-microsoft
requested review from
gaugup,
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1867 +/- ##
===========================================
+ Coverage 79.00% 92.43% +13.42%
===========================================
Files 19 103 +84
Lines 1324 4823 +3499
===========================================
+ Hits 1046 4458 +3412
- Misses 278 365 +87
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
requested changes
Jan 2, 2023
2 similar comments
gaugup
reviewed
Jan 5, 2023
responsibleai/tests/rai_insights/test_rai_insights_validations.py
Outdated
Show resolved
Hide resolved
gaugup
reviewed
Jan 5, 2023
responsibleai/tests/rai_insights/test_rai_insights_validations.py
Outdated
Show resolved
Hide resolved
gaugup
reviewed
Jan 5, 2023
responsibleai/tests/rai_insights/test_rai_insights_validations.py
Outdated
Show resolved
Hide resolved
gaugup
reviewed
Jan 5, 2023
gaugup
reviewed
Jan 5, 2023
gaugup
reviewed
Jan 6, 2023
gaugup
reviewed
Jan 6, 2023
gaugup
reviewed
Jan 6, 2023
responsibleai/tests/rai_insights/test_rai_insights_validations.py
Outdated
Show resolved
Hide resolved
gaugup
approved these changes
Jan 6, 2023
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better error message if all features are dropped.
(responsibleai.exceptions.UserConfigValidationException: There is no feature in the dataset, or all features have been dropped from the dataset )
Description
We added dropped_features where users can choose to drop certain features from the model. In the case when user drops all features from the dataset, we need to have detailed error message "There is no feature in the dataset, or all features have been dropped from the dataset"
Checklist