Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error message if causal treatment features contain dropped features #1868

Merged
merged 9 commits into from
Jan 6, 2023

Conversation

tongyu-microsoft
Copy link
Contributor

This PR adds better error message if causal treatment features contain dropped features:
(responsibleai.exceptions.UserConfigValidationException: '{dropped_feature_name}' in treatment_features has been dropped during training the model)

Description

We added dropped_features where users can choose to drop certain features from the model. In the case when user adds causal component, while treatment features contain dropped features, we need to have a better error message saying "'{dropped_feature_name}' in treatment_features has been dropped during training the model"

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #1868 (1fd7832) into main (2607f35) will increase coverage by 14.33%.
The diff coverage is 100.00%.

❗ Current head 1fd7832 differs from pull request most recent head bf625b7. Consider uploading reports for the commit bf625b7 to get more accurate results

@@             Coverage Diff             @@
##             main    #1868       +/-   ##
===========================================
+ Coverage   79.00%   93.34%   +14.33%     
===========================================
  Files          19       93       +74     
  Lines        1324     4566     +3242     
===========================================
+ Hits         1046     4262     +3216     
- Misses        278      304       +26     
Flag Coverage Δ
unittests 93.34% <100.00%> (+14.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 93.57% <ø> (ø)
...onsibleai/responsibleai/managers/causal_manager.py 95.70% <100.00%> (ø)
raiwidgets/raiwidgets/constants.py
...idgets/raiwidgets/responsibleai_dashboard_input.py
...iwidgets/raiwidgets/explanation_dashboard_input.py
raiwidgets/raiwidgets/error_analysis_constants.py
raiwidgets/raiwidgets/responsibleai_dashboard.py
raiwidgets/raiwidgets/dashboard.py
raiwidgets/raiwidgets/__version__.py
...iwidgets/raiwidgets/fairness_metric_calculation.py
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@tongyu-microsoft tongyu-microsoft merged commit 012cfa2 into main Jan 6, 2023
@tongyu-microsoft tongyu-microsoft deleted the tongy/casualErrorMsg branch January 6, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants