Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_data to CounterfactualData for large data scenario #1885

Merged
merged 6 commits into from
Jan 7, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jan 5, 2023

Description

We need the original query point in CounterfactualData for large data scenarios.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #1885 (a1eeb7e) into main (35f4980) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1885   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          93       93           
  Lines        4572     4574    +2     
=======================================
+ Hits         4268     4270    +2     
  Misses        304      304           
Flag Coverage Δ
unittests 93.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/_interfaces.py 100.00% <100.00%> (ø)
...i/responsibleai/managers/counterfactual_manager.py 97.79% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup enabled auto-merge (squash) January 6, 2023 13:37
@gaugup gaugup mentioned this pull request Jan 7, 2023
3 tasks
@gaugup gaugup merged commit 502edf8 into main Jan 7, 2023
@gaugup gaugup deleted the gaugup/AddTestDataCounterfactualOutput branch January 7, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants