Forecasting: boilerplate only #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
requested review from
tongyu-microsoft,
vinuthakaranth,
xuke444,
RubyZ10 and
hawestra
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
==========================================
+ Coverage 88.92% 93.35% +4.43%
==========================================
Files 56 93 +37
Lines 2139 4572 +2433
==========================================
+ Hits 1902 4268 +2366
- Misses 237 304 +67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gaugup
reviewed
Jan 6, 2023
gaugup
approved these changes
Jan 6, 2023
1 similar comment
imatiach-msft
approved these changes
Jan 6, 2023
|
can you mention the command used to generate the files in the PR description? Just for posterity. |
I'd love to but this was done by John. I think it's an nx command. @xuke444 set it up do he might know. |
vinuthakaranth
approved these changes
Jan 6, 2023
tongyu-microsoft
approved these changes
Jan 6, 2023
hawestra
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes the boilerplate parts out of #1874 and should make it a lot easier to review!
Checklist