Exempt only files from max-lines rule that are already in violation, but not new files #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but not new files
romanlutz
requested review from
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
tongyu-microsoft
approved these changes
Jan 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exempt only files from max-lines rule that are already in violation, but not new files. The global rule says "error" for violations, so by setting "warn" for specific files that are already in violation we can exempt them. Blanket exemptions should be removed.
Checklist